Block Library - Query Pagination Numbers: Print nothing if content is empty#30554
Merged
Conversation
ntsekouras
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.42 MB ℹ️ View Unchanged
|
Contributor
|
Nice little one. I see this in the editor, even though I don't have enough content to paginate. But that's fine, since I need to see something in order to style it:
On the frontend, I still see this empty container, though. Should that not be there?
|
Contributor
Author
Exactly.
It shouldn't be there but by investigating yesterday, it has to do with |
jasmussen
approved these changes
Apr 7, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Cool. Nice little win.
Contributor
Then as far as I can see in my testing, it is working correctly. |
carolinan
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A tiny PR to print nothing if
QueryPaginationNumbershas no content. This can happen when we have aQueryblock with moreposts per pagethan the actual number of published posts.