Block Library: Fix Post Excerpt warnings for RichText in inline containers#30498
Merged
Conversation
ntsekouras
added
[Type] Code Quality
ntsekouras
requested review from
Addison-Stavlo,
aristath,
carolinan,
ellatrix,
jasmussen,
mcsf and
youknowriad
|
Size Change: +38 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Apr 5, 2021
| }, | ||
| "editorStyle": "wp-block-post-excerpt-editor" | ||
| "editorStyle": "wp-block-post-excerpt-editor", | ||
| "style": "wp-block-post-excerpt" |
Member
There was a problem hiding this comment.
What is this and why is a change necessary on the front-end?
Contributor
Author
There was a problem hiding this comment.
This is to match editor with front-end styles.
ellatrix
approved these changes
Apr 5, 2021
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Hopefully we can allow it in the future...
gziolo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some warnings related to
RichText cannot be used with an inline container. It also includes some tiny refactors.Reference: https://developer.wordpress.org/block-editor/reference-guides/richtext/#placeholder-content-separates-from-the-input
Testing instructions?
PostExcerptblock.Show link on new linesetting in block'sInspector controls.