Update the save button label#30439
Merged
Merged
Conversation
jameskoster
added
Needs Design Feedback
|
Size Change: -25 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Contributor
|
That sounds like a good idea! |
carolinan
approved these changes
Apr 6, 2021
Contributor
|
In concept it sounds like a good idea, but thinking about this some more this is what I experience in relation to the save process. At the moment clicking Update Design brings on onward to the Save screen.
Then clicks the Save button. It then goes back to...
I am not certain of what you are suggesting, James. |
Contributor
Author
|
Yes, the flow is the same. We're only changing the label on the button here :) It's no different to the flow to publish a post or page where you click "Publish" in the top bar, then "Publish" again in the sidebar. "Save" is appropriate for site editor because the context is universal – you may have drafted new content, edited a site setting, modified a template or a global style, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Site Editor, the save button in the top bar currently reads "Update design" on larger screens, and "Update" on small screens.
I am proposing that we make this label more generic in order to account for the myriad of different types of changes a user might make in this context. Updating a template part area definition, renaming a reusable block, editing the content of a post / page, changing your homepage settings... these exercises do not strictly qualify as "design" in my opinion.
A simple "Save" label could be more appropriate. What do y'all think?