Make the default padding match the browser's default padding#30277
Merged
Conversation
youknowriad
added
[Type] Enhancement
youknowriad
added
the
Good First Review
carolinan
approved these changes
Mar 26, 2021
|
Size Change: +272 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 26, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Yep. 8 is also a nice round number.
Contributor
Author
|
Funny that a padding change make that e2e test fail consistently. In trunk, it fails too but inconsistently :) |
Contributor
|
I've had some test like that fail because there's room for more text, so it wraps and takes up less space, and suddenly 3 lines of text becomes 2, and then "arrow down 3 times" selects a different block. |
jasmussen
reviewed
Mar 26, 2021
| { | ||
| // Move a bit outside the paragraph. | ||
| x: rect2.x - 10, | ||
| x: rect2.x - 5, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I considered several approaches here:
These options didn't feel great and I just aligned the default padding used with the "body" one, I think it's a sane default that ensures WYSIWYG for themes by default.