Writing Flow: Fix copy pasting non textual blocks#30225
Merged
Conversation
youknowriad
added
[Type] Bug
youknowriad
requested review from
ajitbohra,
ellatrix,
nerrad and
ntwb
as code owners
youknowriad
commented
Mar 25, 2021
| expect( await getEditedPostContent() ).toMatchSnapshot(); | ||
| } ); | ||
|
|
||
| it( 'should copy blocks when non textual elements are focused (image, spacer)', async () => { |
Contributor
Author
There was a problem hiding this comment.
I added a test but the weird thing is that the test pass on trunk even if it fails when you do the same thing manually. I was not able to make the test fail in trunk no matter how I tried to write it.
|
Size Change: +18 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
mcsf
reviewed
Mar 25, 2021
Contributor
mcsf
left a comment
mcsf
left a comment
There was a problem hiding this comment.
The change itself makes total sense. It's only weird that we can't get the E2E to fail when it should.
mtias
approved these changes
Mar 25, 2021
ntsekouras
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you insert an image, or a spacer and click on it then try to copy it using "cmd + c", you'll notice in trunk that it's not copied (at least not consistently) depending on what element of the block is focused.
This PR fixes that bug.