Navigation: Replace arrow with chevron#30180
Merged
Merged
Conversation
jasmussen
added
[Block] Navigation
jasmussen
requested review from
adamziel,
ajitbohra,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
|
Size Change: +68 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
jasmussen
changed the title
mkaz
approved these changes
Mar 25, 2021
Member
mkaz
left a comment
mkaz
left a comment
There was a problem hiding this comment.
Looks good 👍
I tested the change before and after and see the updated icon and no side effects.
Looking at the code the change to margin: 0 for the navigation link raised an eyebrow, just because it is more than an icon change, and potential for a different visual change, though
I didn't notice anything.
Contributor
Author
Yes, in a recent PR I introduced a horizontal margin between menu items, which would allow the vertical sibling inserter to work. However thar margin bled into submenus, which it shouldn't. Not visible in most cases, but it was a small thing. Thanks Marcus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the navigation block submenu triangle with a chevron. Before:
After:
Whether the triangle or the chevron is a subject of taste, hwoever the chevron brings with it a few themer benefits. Specifically, it is an SVG with two strokes and a stroke-width. Which means a theme can:
In that vein, the chevron SVG shape is to an extent more flexible.
How has this been tested?
Please test navigation blocks with custom submenus, and with page list, and on the navigation screen. Verify the chevron looks right.
Checklist: