Icons: Update "close small" icon so that its shape matches the "add" icon dimensionally#30014
Merged
Conversation
jameskoster
added
the
Figma Component
|
Size Change: +11.6 kB (+1%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Mar 19, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Details matter. Nice.
I'm a bit curious why the filesize diff is so much bigger — did the new SVG add a bunch of points? 12 should be enough if I'm counting correctly?
But that's a small thing. Ship it.
aristath
approved these changes
Mar 19, 2021
Contributor
Author
|
@jasmussen I think it's because the old version is two strokes (4 points) whereas the new one is an outlined shape (12 points). Using an outlined shape means the "stroke" will scale along with the size of the icon instead of remaining consistent:
I'm not exactly sure which is the preference here. Different icons behave differently in this respect currently. |
Contributor
|
Oh definitely should be an outline shape! Edit: that was unclear. It should definitely be an outlined, i.e. solid, shape. So your change is preferable. |
Contributor
|
☝️ Edited, because my previous comment was unclear :D |
Member
|
You need to run |
Member
|
Looks like you need to run |
Contributor
Author
|
Tried that, no files were updated 🙈 |
gziolo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
This helps create harmony across the set, particularly is #29759 lands.