Components: Allow multiple words in the autocomplete phrase matcher#29939
Merged
Conversation
gziolo
added
[Type] Bug
gziolo
changed the title
gziolo
changed the title
|
Size Change: +46 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Member
Author
|
I think we should also add a simple e2e test that will prevent future regressions. |
annezazu
reviewed
Mar 17, 2021
Contributor
There was a problem hiding this comment.
From a user point of view, this works GREAT! I can search easily, it works for a variety of use cases, and it's easy to "get out of searching" by clicking the space bar twice. Someone else will need to chime in around the technical approach :) Nice work.
2.word.mov
(new video without audio of me jamming to throw back music haha)
aristath
approved these changes
Mar 18, 2021
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
Code looks good and it improves the user experience 👍
7 tasks
Member
Author
A follow-up ready in #29978. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A try to fix #29495.
The approach I explore works as follows:
My hope is that the review process and test coverage will confirm that this proposal is reasonable.
How has this been tested?
Add a Paragraph block and type
/social iconsand make sure it is able to select a block.Screenshots
Screen.Recording.2021-03-17.at.18.16.59.mov
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: