Add manage with live preview link#29839
Merged
Merged
Conversation
draganescu
requested review from
adamziel,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
draganescu
added
[Type] Task
Contributor
Author
|
@shaunandrews do we have a better idea of where to place this? |
|
Size Change: +70 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
Contributor
|
I'm not sure we even need this button. We don't have it in the new Menu's screen, either. However, if we do think we need it perhaps it can look more like a link (tertiary button):
|
draganescu
force-pushed
the
add/customizer-button-link
branch
from
e315899 to
97bfe18
Compare
Contributor
Author
|
@shaunandrews made it tertiary it now looks like this: manage-live-preview.mp4 |
youknowriad
approved these changes
Mar 25, 2021
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
For me it's a link, so why not just show a regular link. That said, I'll leave that to the designers @shaunandrews
Member
I am also not sure we need this. Here is the ticket for originally adding this button: https://core.trac.wordpress.org/ticket/28032. It was intended to onboard existing users to the Customizer and was intended to be temporary as the thought was that the Widgets screen would be removed one day. |
Contributor
Author
|
Well, yes, but the screen has not been removed, the link has been there in the old screen for ages, there is an obvious thing sill missing from the new editor (preview) and the link is still needed for folks that land here and don't know about the powers in the customizer :) As I also said here I still think we need to keep these detail level features if we don't solve their original problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #26244
This small PR proposes a place for the manage with live preview button, which allows users to switch between the customizer and the stand along widgets editor.
How has this been tested?
Screenshots
The old button
The new button
Types of changes
Adds one button to the widgets complimentary area. Non breaking change.