Fix for current_parsed_blocks value when block has inner blocks #26291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
|
Size Change: 0 B Total Size: 1.2 MB ℹ️ View Unchanged
|
mkaz
approved these changes
Oct 19, 2020
Member
mkaz
left a comment
mkaz
left a comment
There was a problem hiding this comment.
Tested this out and works as expected. 👍
The change makes sense, make sure the global has the right value before render and replace it with the previous value after.
Member
Author
|
cc @tellthemachines we need this (or an alternative that fixes the bug) for the release. Flagging in case I'm not around when that happens. |
oandregal
force-pushed
the
fix/current-parsed-block-inner-blocks
branch
from
f9ce774 to
519a496
Compare
Member
Author
|
I think the change is solid, but there's a couple of things I don't know how to do:
It's a bit late over here so I'll leave the PR unmerged so others can chime in. |
Member
|
@nosolosw I believe the process is to open a core ticket with the diff. I created a ticket and diff here: https://core.trac.wordpress.org/ticket/51569 |
This was referenced Oct 20, 2020
Contributor
Member
Author
|
Thanks for flagging, Fabian. I see there's a core ticket https://core.trac.wordpress.org/ticket/51612 for this as well as a potential solution at WordPress/wordpress-develop#691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #26192 we refactored the block supports mechanism. It works by holding a global
$current_parsed_blocksreference that it uses to determine the attributes that it needs to add to blocks.However, when a block has inner blocks, that reference isn't updated so inner blocks end up inheriting the parent's properties (style and classes).
How to test
This is what I've done:
wp-includes/class-wp-block.phpclass with the contents of this PR.lielements) don't have thewp-social-linksclass attached. It should be present in the parent (ulelement).