Skip to content

Remove WP_REST_Widget_Utils_Controller class #26274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimothyBJacobs merged 5 commits into from
Oct 19, 2020
Merged

Remove WP_REST_Widget_Utils_Controller class #26274

TimothyBJacobs merged 5 commits into from
Oct 19, 2020

Conversation

@spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Oct 19, 2020

Fixed #26092

Description

Remove WP_REST_Widget_Utils_Controller class as no longer needed. Replaced with widget type endpoint.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@spacedmonkey spacedmonkey self-assigned this Oct 19, 2020
@spacedmonkey spacedmonkey added [Feature] Widgets Screen The block-based screen that replaced widgets.php. Core REST API Task Task for Core REST API efforts REST API Interaction Related to REST API labels Oct 19, 2020
@github-actions
Copy link

github-actions bot commented Oct 19, 2020 •
edited
Loading

Size Change: +5 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/edit-widgets/index.js 26.6 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.6 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.93 kB 0 B
build/block-library/editor.css 8.93 kB 0 B
build/block-library/index.js 144 kB 0 B
build/block-library/style-rtl.css 7.71 kB 0 B
build/block-library/style.css 7.71 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.77 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 170 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 684 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.35 kB 0 B
build/edit-site/index.js 21.6 kB 0 B
build/edit-site/style-rtl.css 3.8 kB 0 B
build/edit-site/style.css 3.81 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.6 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.35 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.61 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.23 kB 0 B

compressed-size-action

TimothyBJacobs
TimothyBJacobs requested changes Oct 19, 2020
View reviewed changes
spacedmonkey
spacedmonkey commented Oct 19, 2020
View reviewed changes
@spacedmonkey
Copy link
Member Author

spacedmonkey commented Oct 19, 2020

Pinging @adamziel and @noisysocks for review.

@TimothyBJacobs
Copy link
Member

TimothyBJacobs commented Oct 19, 2020

This worked in my basic tests, waiting on #26164 to land to do final confirmation.

@TimothyBJacobs TimothyBJacobs merged commit 849e7a5 into master Oct 19, 2020
@TimothyBJacobs TimothyBJacobs deleted the fix/remove-unneed-api branch October 19, 2020 17:51
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimothyBJacobs TimothyBJacobs TimothyBJacobs approved these changes

@adamziel adamziel Awaiting requested review from adamziel

@draganescu draganescu Awaiting requested review from draganescu

@kevin940726 kevin940726 Awaiting requested review from kevin940726

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@spacedmonkey spacedmonkey

Labels

Core REST API Task Task for Core REST API efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. REST API Interaction Related to REST API

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

Remove WP_REST_Widget_Utils_Controller class and form-renderer method

3 participants

@spacedmonkey @TimothyBJacobs