Size Change: +1.32 kB (0%)

Total Size: 1.19 MB

_{compressed-size-action}

I wonder if we could tweak one of the E2E tests that we have, e.g. cpt-locking.php, to include deprecated block types.

Now, this only fixes the issue of templates not having their blocks converted from deprecated types (e.g. core/text, core/embed-wordpress). It does not fix the issue of the white screen of death (WSOD) triggered whenever a block in a template is not known. This is something to track in an issue, if there isn't one already.

Thanks for reviewing @mcsf - very valuable feedback as always 💯

I wonder if we could tweak one of the E2E tests that we have, e.g. cpt-locking.php, to include deprecated block types.

The general approach seems right.

Since I wanted to get feedback about the approach I'll improve the implementation and add tests for sure and address the other feedback as well.

Now, this only fixes the issue of templates not having their blocks converted from deprecated types (e.g. core/text, core/embed-wordpress). It does not fix the issue of the white screen of death (WSOD) triggered whenever a block in a template is not known. This is something to track in an issue, if there isn't one already.

There was a relevant issue about handling the error better here: #21718, which I closed as there was a better error msg and handled earlier. This still results in WSOD though.

I think it's a separate issue and I'm not really sure what the best approach of this would be to be honest.

There was a relevant issue about handling the error better here: #21718, which I closed as there was a better error msg and handled earlier. This still results in WSOD though.

I think it's a separate issue and I'm not really sure what the best approach of this would be to be honest.

Either reopen that issue or make a more specific one — both are fine.

I'm not really sure what the best approach [is]

The editor is already equipped to handle unknown blocks if they are loaded from post_content. We just need to make sure this is also somehow applied to CPT templates. See getUnregisteredTypeHandlerName, setUnregisteredTypeHandlerName and core/missing.

Either reopen that issue or make a more specific one — both are fine.

I'll open a new one. Thanks for the context too!

The other thing is looking at how we're using ErrorBoundary and figuring out why we got a full WSOD instead of a "The editor has encountered an unexpected error" message.