-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add legacy widget inspector card component #26142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
draganescu
merged 4 commits into
master
from
add/inspector-card-for-legacy-widget-block
Oct 15, 2020
Merged
Add legacy widget inspector card component #26142
draganescu
merged 4 commits into
master
from
add/inspector-card-for-legacy-widget-block
Oct 15, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +150 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Oct 15, 2020
Contributor
draganescu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor
|
It definitely works for now, @talldan! Thanks for getting to this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Legacy Widget
Affects the Legacy Widget Block - used for displaying Classic Widgets
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #24870
Improves how the details about the legacy widget are shown in the inspector:

This is a bit of a hybrid of some of the designs, as I don't think we realized the border at the top could be bypassed, and i know at the same time there was a desire to keep the description. Happy to iterate further on how it looks if we think further changes are needed.
How has this been tested?
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: