FullscreenMode: remove the is-fullscreen-mode CSS class from body on unmount #26103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Bug
|
Size Change: +31 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 14, 2020
|
|
||
| if ( this.props.isActive ) { | ||
| document.body.classList.remove( 'is-fullscreen-mode' ); | ||
| } |
Contributor
There was a problem hiding this comment.
I think rewriting that component as hook is probably the best path forward. At the time we introduce this one, these were not available.
Member
Author
There was a problem hiding this comment.
Agreed. With useEffect, the code will be much shorter. I'll do it in the next PR. In this one, I wanted to focus on the actual bugfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FullscreenModecomponent adds theis-fullscreen-modeCSS class tobodywhen mounted withisActive={ true }, adds and removes when theisActiveprop changes, but doesn't remove it when the component is unmounted.This bug is not currently observable because the editor is always running in
wp-admincontext, mounted only once and never unmounted. As soon as theFullscreenModecomponent is used in a SPA with client-side router, unmounting on navigation to a different route would leave a staleis-fullscreen-modeclass behind.