Add unsaved changes warning to widgets screen #26081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
tellthemachines and
youknowriad
as code owners
|
Size Change: +129 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Contributor
Author
|
There's a separate issue in #26084 I noticed in working on this, particular changes don't trigger the warning. The update button is also affected by this, so I'm considering it a separate bug to this change. |
tellthemachines
approved these changes
Oct 14, 2020
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Potentially this component could be moved to block-editor to remove the duplication?
I don't have context on why the editor package is not meant to be used here. But UnsavedChangesWarning uses core selectors so wouldn't be suitable for moving to block-editor as is. Probably best to duplicate for now, and revisit later if it becomes a problem 😅
This works well!
Contributor
There was a problem hiding this comment.
Does this comment still make sense in the current context?
talldan
force-pushed
the
add/save-prompt-to-widgets-screen
branch
from
2c6e60f to
9053f47
Compare
kevin940726
requested changes
Oct 14, 2020
packages/edit-widgets/src/components/layout/unsaved-changes-warning.js
Outdated
Show resolved
Hide resolved
kevin940726
approved these changes
Oct 14, 2020
packages/edit-widgets/src/components/layout/unsaved-changes-warning.js
Outdated
Show resolved
Hide resolved
talldan
force-pushed
the
add/save-prompt-to-widgets-screen
branch
from
d6c2512 to
bca1838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #26076.
Adds the
UnsavedChangesWarningcomponent to the widgets screen.I've copied this component from the
editorpackage, since the widgets screen has no dependency oneditor(see #25859).Potentially this component could be moved to
block-editorto remove the duplication?How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist: