Skip to content

Pullquote block: use hooks + API v2 #26068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ellatrix merged 4 commits into from
Oct 14, 2020
Merged

Pullquote block: use hooks + API v2 #26068

ellatrix merged 4 commits into from
Oct 14, 2020

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Oct 13, 2020

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@ZebulanStanphill ZebulanStanphill added [Block] Pullquote (deprecated) Affects the Pullquote Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality labels Oct 13, 2020
@github-actions
Copy link

github-actions bot commented Oct 13, 2020 •
edited
Loading

Size Change: -1.03 kB (0%)

Total Size: 1.19 MB

Filename Size Change
build/block-library/index.js 143 kB -1.03 kB (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 667 B 0 B
build/block-directory/index.js 8.56 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/style-rtl.css 7.71 kB 0 B
build/block-library/style.css 7.71 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 169 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 685 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.3 kB 0 B
build/edit-post/style.css 6.29 kB 0 B
build/edit-site/index.js 21.3 kB 0 B
build/edit-site/style-rtl.css 3.86 kB 0 B
build/edit-site/style.css 3.86 kB 0 B
build/edit-widgets/index.js 21.3 kB 0 B
build/edit-widgets/style-rtl.css 2.97 kB 0 B
build/edit-widgets/style.css 2.97 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 45.4 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.69 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ellatrix ellatrix force-pushed the try/pullquote-use-hooks branch from 7b08e85 to a5dfe3f Compare October 14, 2020 08:16
@ellatrix ellatrix changed the title Pullquote block: use hooks and API v2 Pullquote block: use hooks + API v2 Oct 14, 2020
youknowriad
youknowriad reviewed Oct 14, 2020
View reviewed changes
packages/block-library/src/pullquote/edit.js Outdated
const { setTextColor } = this.props;
function pullQuoteTextColorSetter( colorValue ) {
setTextColor( colorValue );
this.wasTextColorAutomaticallyComputed = false;
Copy link
Contributor

@youknowriad youknowriad Oct 14, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use a ref for this?

Copy link
Member Author

@ellatrix ellatrix Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks like I forgot some of this.* :)

@ellatrix ellatrix requested a review from ntsekouras October 14, 2020 08:52
ntsekouras
ntsekouras approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellatrix
Copy link
Member Author

ellatrix commented Oct 14, 2020

Thanks for checking!

This is the only block we have that derives some data from the block's className, which must now be retrieved from useBlockProps() instead of a className prop on the edit component.

@ellatrix ellatrix merged commit 70eafd2 into master Oct 14, 2020
@ellatrix ellatrix deleted the try/pullquote-use-hooks branch October 14, 2020 10:22
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 14, 2020
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Oct 14, 2020

This is the only block we have that derives some data from the block's className, which must now be retrieved from useBlockProps() instead of a className prop on the edit component.

This feels like a code smell to me. I think stuff like isSolidColorStyle should be calculated based on dedicated attributes like mainColor and textColor, not CSS class name string parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@ntsekouras ntsekouras ntsekouras approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@Soean Soean Awaiting requested review from Soean

@talldan talldan Awaiting requested review from talldan

Assignees

No one assigned

Labels

[Block] Pullquote (deprecated) Affects the Pullquote Block [Package] Block library /packages/block-library [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

5 participants

@ellatrix @ZebulanStanphill @youknowriad @ntsekouras