Skip to content

Add widget type endpoint. #26042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TimothyBJacobs merged 9 commits into from
Oct 14, 2020
Merged

Add widget type endpoint. #26042

TimothyBJacobs merged 9 commits into from
Oct 14, 2020

Conversation

@spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Oct 12, 2020

Description

Add widget type endpoint.

To test.

__experimental/widget-types
__experimental/widget-types/<name>

Fixes: #25969

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@spacedmonkey spacedmonkey mentioned this pull request Oct 12, 2020
Merged
6 tasks
TimothyBJacobs
TimothyBJacobs reviewed Oct 12, 2020
View reviewed changes
TimothyBJacobs
TimothyBJacobs reviewed Oct 12, 2020
View reviewed changes
TimothyBJacobs
TimothyBJacobs reviewed Oct 12, 2020
View reviewed changes
TimothyBJacobs
TimothyBJacobs reviewed Oct 12, 2020
View reviewed changes
TimothyBJacobs
TimothyBJacobs reviewed Oct 12, 2020
View reviewed changes
TimothyBJacobs
TimothyBJacobs reviewed Oct 12, 2020
View reviewed changes
@spacedmonkey spacedmonkey self-assigned this Oct 12, 2020
@spacedmonkey spacedmonkey added [Feature] Widgets Screen The block-based screen that replaced widgets.php. Core REST API Task Task for Core REST API efforts REST API Interaction Related to REST API [Priority] High Used to indicate top priority items that need quick attention labels Oct 12, 2020
@spacedmonkey
Copy link
Member Author

spacedmonkey commented Oct 12, 2020

@TimothyBJacobs I would like to get this merged before #25232 . From there I will rebase the PR and add links into #25232

@TimothyBJacobs
Copy link
Member

TimothyBJacobs commented Oct 12, 2020

We can merge this before #25232, but that PR should stay the same so that the client can implement changes after it is merged.

spacedmonkey and others added 5 commits October 14, 2020 01:16
@spacedmonkey
Add test for legacy.
1e35ec4
@spacedmonkey
Add a test.
3bd96a1
@TimothyBJacobs
Switch to wp/v2 namespace.
6ad1945 
This is either going to land in Gutenberg 9.2.0 for release in 5.6 which means
it has to be stable anyway, or if that doesn't happen we can revert.
@TimothyBJacobs
Merge branch 'master' into feature/widget-type
5bb32d1
@TimothyBJacobs
Syntax error
45599fd
TimothyBJacobs
TimothyBJacobs approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@TimothyBJacobs TimothyBJacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's get this in so the client can start adjusting.

@TimothyBJacobs TimothyBJacobs merged commit 1862791 into WordPress:master Oct 14, 2020
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 14, 2020
@adamziel adamziel mentioned this pull request Oct 14, 2020
Closed
@talldan
Copy link
Contributor

talldan commented Oct 14, 2020

Hey @TimothyBJacobs and @spacedmonkey, just seeing some failing tests in master:

1) REST_Widget_Types_Controller_Test::test_get_items
87
Failed asserting that actual size 18 matches expected size 20.

Not sure how this one materialized, as I can't see the error in this PR.

@talldan
Copy link
Contributor

talldan commented Oct 14, 2020

Thanks for the fix 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimothyBJacobs TimothyBJacobs TimothyBJacobs approved these changes

@adamziel adamziel Awaiting requested review from adamziel

Assignees

@spacedmonkey spacedmonkey

Labels

Core REST API Task Task for Core REST API efforts [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Priority] High Used to indicate top priority items that need quick attention REST API Interaction Related to REST API

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

Add Widget Type endpoint

3 participants

@spacedmonkey @TimothyBJacobs @talldan