-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Tweak styles of the document actions area #26038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak styles of the document actions area #26038
Conversation
|
cc @shaunandrews @jameskoster @dubielzyk, my thought is that we can use this PR to finalize any "nitpicky" CSS issues for the document actions area. (like making sure it is consistent and all that stuff) |
|
Size Change: -149 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
|
Also tried adding a basic section heading as in #24020. Not sure what we're doing to handle colors for css-in-js though! |
|
I think the padding between the text and arrow should be reduced by 2-4px, but I think that might mess up the outline on the buttons? |
9e85ce6 to
e8861fd
Compare
|
cc @dubielzyk @shaunandrews we have some options for spacing here, assuming that the distance between the right side of the title and the left side of the chevron are equal in both options. Option 1. We leave the margin and padding alone, letting the text overlap the button slightly while focused. (36x36px size) Option 2. We add 4px of margin, and then adjust the width of the button such that the distance doesn't change because of the extra margin. (28x36px) Option 3. Since the button is slightly squished in option2, make the height match the width (resulting in a smaller button. With 4px of margin on the edge, this is now (28x28px) We can make the margin a bit less as well, but 4px seems to be the minimum which looks good. Here's 2px of margin along with correct height/width adjustments. This button is 32x32px. so I don't forget, the formula for calculating this is |
|
I also want to note that if we switch to the text component like @jameskoster mentioned, then we don't get a grayed-out text, it just defaults to the normal body style. It still contrasts will with the small subheading style though. |
e8861fd to
ec5e615
Compare
vindl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀






Description
closes #26035
Tweaking the styles of the document actions area in the site editor. Would love to get the CSS into a final state here (cc @shaunandrews @jameskoster). I also tried using the
Textcomponent to handle font-related styles, and it's pretty nice to defer that work elsewhere.I'm mostly unsure about padding and margin for the document actions dropdown area.
Since this uses
Text, the text style is a bit different in the header:Checklist: