Skip to content

Conversation

@noahtallen
Copy link
Member

@noahtallen noahtallen commented Oct 12, 2020

Description

closes #26035

Tweaking the styles of the document actions area in the site editor. Would love to get the CSS into a final state here (cc @shaunandrews @jameskoster). I also tried using the Text component to handle font-related styles, and it's pretty nice to defer that work elsewhere.

I'm mostly unsure about padding and margin for the document actions dropdown area.

Since this uses Text, the text style is a bit different in the header:

2020-10-12 12 47 02

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@noahtallen noahtallen added [Type] Code Quality Issues or PRs that relate to code quality [Feature] Full Site Editing labels Oct 12, 2020
@noahtallen noahtallen self-assigned this Oct 12, 2020
@noahtallen
Copy link
Member Author

cc @shaunandrews @jameskoster @dubielzyk, my thought is that we can use this PR to finalize any "nitpicky" CSS issues for the document actions area. (like making sure it is consistent and all that stuff)

@github-actions
Copy link

github-actions bot commented Oct 12, 2020

Size Change: -149 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/components/index.js 169 kB +43 B (0%)
build/edit-site/index.js 21.4 kB -19 B (0%)
build/edit-site/style-rtl.css 3.8 kB -88 B (2%)
build/edit-site/style.css 3.81 kB -85 B (2%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.6 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 130 kB 0 B
build/block-editor/style-rtl.css 11 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/index.js 142 kB 0 B
build/block-library/style-rtl.css 7.71 kB 0 B
build/block-library/style.css 7.71 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 684 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.37 kB 0 B
build/edit-post/style.css 6.35 kB 0 B
build/edit-widgets/index.js 21.6 kB 0 B
build/edit-widgets/style-rtl.css 3.09 kB 0 B
build/edit-widgets/style.css 3.09 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/index.js 42.4 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.04 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.07 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@noahtallen
Copy link
Member Author

Also tried adding a basic section heading as in #24020. Not sure what we're doing to handle colors for css-in-js though!

@noahtallen noahtallen linked an issue Oct 12, 2020 that may be closed by this pull request
@dubielzyk
Copy link

I think the padding between the text and arrow should be reduced by 2-4px, but I think that might mess up the outline on the buttons?

@noahtallen noahtallen force-pushed the try/use-text-component-for-document-actions branch from 9e85ce6 to e8861fd Compare October 15, 2020 01:51
@noahtallen
Copy link
Member Author

cc @dubielzyk @shaunandrews we have some options for spacing here, assuming that the distance between the right side of the title and the left side of the chevron are equal in both options.

Option 1. We leave the margin and padding alone, letting the text overlap the button slightly while focused. (36x36px size)
Screen Shot 2020-10-14 at 7 31 21 PM

Option 2. We add 4px of margin, and then adjust the width of the button such that the distance doesn't change because of the extra margin. (28x36px)
Screen Shot 2020-10-14 at 7 31 40 PM

Option 3. Since the button is slightly squished in option2, make the height match the width (resulting in a smaller button. With 4px of margin on the edge, this is now (28x28px)
Screen Shot 2020-10-14 at 7 35 36 PM

We can make the margin a bit less as well, but 4px seems to be the minimum which looks good. Here's 2px of margin along with correct height/width adjustments. This button is 32x32px.
Screen Shot 2020-10-14 at 7 40 32 PM

so I don't forget, the formula for calculating this is 0.5*buttonWidth + leftMargin = 18px. To adjust buttonWidth properly, you have to set min-width to 0 and then change the padding which defaults to 6px. Note that 18px is the default distance between the left element and the center of the chevron.

@noahtallen
Copy link
Member Author

I also want to note that if we switch to the text component like @jameskoster mentioned, then we don't get a grayed-out text, it just defaults to the normal body style. It still contrasts will with the small subheading style though.

@noahtallen noahtallen force-pushed the try/use-text-component-for-document-actions branch from e8861fd to ec5e615 Compare October 15, 2020 22:10
@noahtallen
Copy link
Member Author

current look:
2020-10-15 15 57 25

Screen Shot 2020-10-15 at 3 59 24 PM

Copy link
Member

@vindl vindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@noahtallen noahtallen merged commit f707955 into master Oct 15, 2020
@noahtallen noahtallen deleted the try/use-text-component-for-document-actions branch October 15, 2020 23:29
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch to Text component in document actions area

5 participants