Performance: Remove transition on block selection indicator. #25974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although fading a box shadow should be performant, for whatever reason it feels clunky in the editor. This PR simply removes the transition, making it feel much more responsive. I'm not finding myself missing the fade.
jasmussen
added
[Type] Enhancement
|
Size Change: -65 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
Member
|
It truly took me far too long than it should have to work out what the effect was it was trying to do, which is a strong indicator that yes this isn't performant. +1 from me to remove this, it seems like a great win and anything we can do to make things more performant I think is great. |
Contributor
Author
|
In practice, the actual performance game is probably very tiny, and mostly on high res screens. However the perceived performance gain, I feel, is quite big on any screen. Now selection feels instant because it looks instant, even if it's only marginally faster. |
ellatrix
approved these changes
Oct 9, 2020
Contributor
Author
|
Thank you Ella! |
Contributor
|
This is great. Nice work! |
Contributor
|
Big fan of perceived performance gains 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although fading a box shadow should be performant, for whatever reason it feels clunky in the editor:
This PR simply removes the transition, making it feel much more responsive. I'm not finding myself missing the fade: