Skip to content

Conversation

@kishanjasani
Copy link
Contributor

@kishanjasani kishanjasani commented Oct 8, 2020

Fixes: #22188

Description

This PR will resolve the issue that occurs in the gallery.

How has this been tested?

I have tested it on twenty twenty-one theme and twenty-twenty theme. It works as expected and also won't break any style required for backward compatibility.

Screenshots

Editor Style:
screenshot-guten local-2020 10 09-01_13_21

Frontend Style:
screenshot-guten local-2020 10 09-01_14_42

Types of changes

Bug Fix - Non-breaking change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aristath aristath requested a review from kjellr October 9, 2020 08:32
@aristath
Copy link
Member

aristath commented Oct 9, 2020

@kjellr Sanity check, can you please also review this PR to be sure we're OK?

Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thank you! Just left one comment suggesting we move this rule in alongside with the rest of the styles in this file.

@kishanjasani kishanjasani requested a review from kjellr October 9, 2020 18:21
@kishanjasani kishanjasani requested a review from kjellr October 9, 2020 18:30
Copy link
Contributor

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @kishanjasani!

@kjellr kjellr merged commit 8b376f2 into WordPress:master Oct 9, 2020
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 9, 2020
@kishanjasani kishanjasani deleted the issue/GH-22188 branch October 9, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gallery Captions are centered in the editor, but not on the sites

3 participants