New hook: useDebounce for speak function #25948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
ajitbohra,
cameronvoell,
etoledom,
guarani and
youknowriad
as code owners
ellatrix
commented
Oct 8, 2020
|
Size Change: -19 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
add/use-speak
branch
from
ff2068e to
e5d6066
Compare
ellatrix
force-pushed
the
add/use-speak
branch
from
88b579d to
caac9e6
Compare
ellatrix
added
the
[Type] New API
Contributor
I actually wonder if this is better. In general you don't want to debounce just the announcement, sometimes you want to also debounce the search at the same time... Regardless, I don't have blockers here but I think |
Member
Author
|
@youknowriad I agree that it's useless atm, just like it was useless in the HoC. Do you think it could provide future compatibility if speak were to use React instead of direct DOM manipulation? In any case it seems too late for that because speak is already exposed in the a11y package. |
Member
Author
|
I will change it to simply having useDebounce |
ellatrix
force-pushed
the
add/use-speak
branch
from
8d39038 to
28f3578
Compare
ellatrix
changed the title
Member
Author
|
@youknowriad Is this better? |
youknowriad
reviewed
Oct 12, 2020
| * @param {...any} args Arguments passed to Lodash's `debounce`. | ||
| */ | ||
| export default function useDebounce( ...args ) { | ||
| const debounced = useMemoOne( () => debounce( ...args ), args ); |
Contributor
There was a problem hiding this comment.
I'm not sure I understand why useMemo is not enough?
Member
Author
There was a problem hiding this comment.
Well, it could have a debounced call randomly cancelled. useMemoOne guarantees that will never happen. We're using it in useSelect too.
youknowriad
approved these changes
Oct 12, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Looks good, I'm not sure about the extra use-memo-one dependency. By reading their README, it seems useMemo should be sufficient for us?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
useSpeakanduseDebouncedSpeakas a replacement forwithSpokenMessages(introduced in #2107).useDebouncecould be useful to export, but I left it internal for now until we see use cases.useSpeakseems sort of useless, but it might be valuable for future compatibility and I like that both function have a hook instead of just one.One alternative I've considered is to only export
useDebounceas a hook and components debouncespeakthemselves, but I think there's value in having a consistent wait time.Motivation: I need this to rewrite the
Autocompletecomponent as a hook, to be used for an experimentaluseRichTexthook.How has this been tested?
Screenshots
Types of changes
Checklist: