Fix e2e tests related to template parts #25923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
requested review from
ajitbohra,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
noahtallen
requested review from
Addison-Stavlo,
Copons,
david-szabo97,
jeyip,
mattwiebe and
vindl
noahtallen
added
[Package] E2E Tests
6 tasks
|
Size Change: -37 B (0%) Total Size: 1.18 MB
ℹ️ View Unchanged
|
noahtallen
commented
Oct 7, 2020
packages/edit-site/src/components/left-sidebar/navigation-panel/menus/template-parts.js
Outdated
Show resolved
Hide resolved
noahtallen
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
noahtallen
changed the title
Fixes an issue where the title in the tests did not match the DOM.
noahtallen
force-pushed
the
fix/failing-e2e-tests
branch
from
a3659e1 to
58a9ea8
Compare
noahtallen
force-pushed
the
fix/failing-e2e-tests
branch
from
58a9ea8 to
99f6b35
Compare
noahtallen
changed the title
Addison-Stavlo
approved these changes
Oct 7, 2020
Contributor
Addison-Stavlo
left a comment
Addison-Stavlo
left a comment
There was a problem hiding this comment.
This looks and works well for me regarding fixing the tests failing regarding the site editor. The other failing tests are unrelated, but will also need to be addressed.
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There are still other e2e tests failing. This just fixes the most immediate issues. I haven't been able to track down solid fixes for the others quite yet.
Description
A few e2e tests are failing in master. The issue (I think) is that the text of a button is "Template Part", but the test queries for an xpath with text "Template part".
Additionally, there was an issue where the new nav sidebar did not display demo template parts, because it was querying for template parts associated only with the current theme.
This also reverts the previous attempt to skip failing tests in #25918.
Closes #25919
How has this been tested?
e2e tests should not report issues with template parts in this PR.
Screenshots
Types of changes
Bug fix.
Checklist: