Social Links: Avoid conflict with themes ul text-indent #25916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
added
the
[Block] Social
Member
Author
|
@enriquesanchez or @aleone89 Can you confirm that this fixes the issue reported in #20893 ? |
|
Size Change: +15 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
mkaz
force-pushed
the
fix/20893-social-alignment
branch
from
1cba97d to
9c957bb
Compare
The social links could pick up the text-indent from some themes global <ul> settings. This explictly sets the social link text-indent to 0
mkaz
force-pushed
the
fix/20893-social-alignment
branch
from
9c957bb to
d718efb
Compare
Contributor
|
Hi @mkaz! I can confirm that this fixes the indent conflict. That said, I was no longer able to reproduce the issue in #20893. With or without this PR, the social links looked OK on the front-end.
Maybe that is why? |
Member
Author
|
@enriquesanchez yep, the other margin fixes is already in place. The Jetpack issue reported with regards to text-indent was attached to that original issue, so I kept it open. So once approved and merged this PR will close it. |
enriquesanchez
requested review from
enriquesanchez and
nicolad
and removed request for
nicolad
enriquesanchez
approved these changes
Oct 12, 2020
Contributor
enriquesanchez
left a comment
enriquesanchez
left a comment
There was a problem hiding this comment.
Thanks @mkaz! This looks good to me 👍
ZebulanStanphill
added
the
CSS Styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The social links could pick up the text-indent from some themes global
<ul>settings.This explictly sets the social link text-indent to 0
Fixes #20893
How has this been tested?
<ul>text-indent (or modify in inspector)Screenshots
Types of changes