Skip to content

Site editor: Store navigation panel's active menu state in the store #25906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
david-szabo97 merged 2 commits into from
Oct 8, 2020
Merged

Site editor: Store navigation panel's active menu state in the store #25906

david-szabo97 merged 2 commits into from
Oct 8, 2020

Conversation

@david-szabo97
Copy link
Member

@david-szabo97 david-szabo97 commented Oct 7, 2020 •
edited
Loading

Description

Store navigation panel's active menu state in the global state. Whenever we open the navigation panel it will show the menu where we last closed it.

How has this been tested?

  • yarn wp-env start
  • Enable FSE
  • Open Site Editor
  • Click site logo to toggle the navigation sidebar

Types of changes

New feature

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@david-szabo97 david-szabo97 self-assigned this Oct 7, 2020
@github-actions
Copy link

github-actions bot commented Oct 7, 2020 •
edited
Loading

Size Change: +110 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/edit-site/index.js 21 kB +110 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.55 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 129 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/index.js 144 kB 0 B
build/block-library/style-rtl.css 7.66 kB 0 B
build/block-library/style.css 7.65 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.5 kB 0 B
build/components/index.js 169 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.43 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 685 B 0 B
build/data/index.js 8.61 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.29 kB 0 B
build/edit-post/style.css 6.27 kB 0 B
build/edit-site/style-rtl.css 3.73 kB 0 B
build/edit-site/style.css 3.73 kB 0 B
build/edit-widgets/index.js 21.3 kB 0 B
build/edit-widgets/style-rtl.css 3 kB 0 B
build/edit-widgets/style.css 3 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.4 kB 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@Copons Copons requested review from jeyip and vindl October 7, 2020 15:20
Copons
Copons approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@Copons Copons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The comment I've left is minor: feel free to merge after addressing it!

@Copons
Copy link
Contributor

Copons commented Oct 7, 2020

It just occurred to me: would it make sense to have an actual navigationPanel or sidebar state?
I can imagine that eventually there will be more options that we might need to keep in store.

(No need to change this PR, just something to keep in mind for the future).

@david-szabo97 david-szabo97 force-pushed the add/site-editor-save-navigation-panel-state-to-store branch from 8738202 to 987a373 Compare October 8, 2020 07:53
@david-szabo97 david-szabo97 merged commit 74d07e6 into master Oct 8, 2020
@david-szabo97 david-szabo97 deleted the add/site-editor-save-navigation-panel-state-to-store branch October 8, 2020 08:21
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 8, 2020
@david-szabo97
Copy link
Member Author

david-szabo97 commented Oct 8, 2020

Yes, that would make sense. In the long run we will definitely have more state to store.

@david-szabo97 david-szabo97 mentioned this pull request Oct 13, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Copons Copons Copons approved these changes

@noahtallen noahtallen Awaiting requested review from noahtallen

@youknowriad youknowriad Awaiting requested review from youknowriad

@vindl vindl Awaiting requested review from vindl

@jeyip jeyip Awaiting requested review from jeyip

Assignees

@david-szabo97 david-szabo97

Labels

None yet

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@david-szabo97 @Copons