Skip to content

Conversation

@sarayourfriend
Copy link
Contributor

Description

This PR updates the ExternalLink component to use CSS-in-JS similar to how newer components do like the AnglePickerControl and Text. This also maintains the existing classname on the Icon even though it isn't being used by the component itself, it allows the Icon to still be targeted by consumers, making this a non-breaking change.

How has this been tested?

I've run storybook and observed that there are new visual differences in before and after.

Screenshots

Before:
Captura de Tela 2020-09-30 às 10 45 33

After:
Captura de Tela 2020-09-30 às 10 43 53

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@sarayourfriend
Copy link
Contributor Author

/cc @ItsJonQ

Copy link

@ItsJonQ ItsJonQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 from me! Thank you @saramarcondes ! Excited to see more components using the CSS-in-JS solutions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants