Size Change: +6.33 kB (0%)

Total Size: 1.18 MB

_{compressed-size-action}

Note: There's curious behavior (that exists on master). When a template part or template part child is already selected, the document secondary title will still change when a different template part is hovered. It seems odd to me, but I was wondering what other folks thought of this.

the document secondary title will still change when a different template part is hovered. It seems odd to me, but I was wondering what other folks thought of this.

I think this would be good to think about in a follow-up. I don't know what we expect to happen design-wise

Ok, wow, this is way better than it was before! Nice job.

Two thoughts:

1. Should the main text be bold when it's the only item in the header?
2. Should there be a slight transition when the text changes to bold? I think the designs might include that

Another note is that we should include the reduce-motion mixin

1. Should the main text be bold when it's the only item in the header?
I can see this going either way. I think it makes sense to make the document title more discoverable, even if it's the only item. If, however, we're trying to draw attention to the hover and select interactions, I think the current behavior makes more sense (although it can be a bit jarring).

Thoughts @shaunandrews?

See Addison's comment below . Adding in the boldness now.

2. Should there be a slight transition when the text changes to bold? I think the designs might include that
I should've left a note for this, but I excluded this transition because font-weight changes cause reflow. The transition isn't the smoothest. I'm not sure if there's a way around this, but I can try exploring this further if it's important to us.

Side Note:
We'll probably want a strategy for longer template part titles (15+ characters). At a certain point, the title will butt up against either side of the topbar and affect the responsiveness of the topbar buttons. Maybe something like text ellipses?

Another note is that we should include the reduce-motion mixin

I love that this exists. 🚀 Great callout Noah.

1. Should the main text be bold when it's the only item in the header?

From the mock ups shared (#25348 (comment)) it looks like it should be bold when it is the only item.

I should've left a note for this, but I excluded this transition because font-weight changes cause reflow.

Ah, interesting!

At a certain point, the title will butt up against either side of the topbar and affect the responsiveness of the topbar buttons.

Yeah, that top bar breaks easily when it overflows. Hopefully getting rid of that double dropdown in the near future will help. But we may still need to consider what to do about excessively long names. Maybe a max-width for the element and either let it overflow or cut off the overflow? 🤔 Either way, thats outside of this PR.

From the mock ups shared (#25348 (comment)) it looks like it should be bold when it is the only item.

🤦‍♂️ Y'all are totally right. Don't know why I didn't see that. I'm switching it now!

I'll make a follow up issue for the width of characters. Interesting about the font weight transition! Avoiding it makes sense to me.

I guess we should rebase on master first though :)

should we base these off master / merge to that? I see this is still opened against the hover PR which is still in ???s (hopefully g2g soon)

I'll make a follow up issue for the width of characters

Here: #25783