Skip to content

RichText: remove native props for web #25700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ellatrix merged 2 commits into from
Sep 29, 2020
Merged

RichText: remove native props for web #25700

ellatrix merged 2 commits into from
Sep 29, 2020

Conversation

@ellatrix
Copy link
Member

@ellatrix ellatrix commented Sep 29, 2020

Description

These props are eventually passed down to the container element, which causes a bunch or error to be logged. They should only be passed down in native context.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@github-actions
Copy link

github-actions bot commented Sep 29, 2020 •
edited
Loading

Size Change: -472 B (0%)

Total Size: 1.17 MB

Filename Size Change
build/block-editor/index.js 129 kB -25 B (0%)
build/rich-text/index.js 13 kB -447 B (3%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.61 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.6 kB 0 B
build/block-library/editor.css 8.6 kB 0 B
build/block-library/index.js 135 kB 0 B
build/block-library/style-rtl.css 7.61 kB 0 B
build/block-library/style.css 7.6 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.5 kB 0 B
build/components/index.js 168 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.42 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 1.27 kB 0 B
build/data/index.js 8.42 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.7 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.25 kB 0 B
build/edit-post/style.css 6.24 kB 0 B
build/edit-site/index.js 20.5 kB 0 B
build/edit-site/style-rtl.css 3.74 kB 0 B
build/edit-site/style.css 3.74 kB 0 B
build/edit-widgets/index.js 18.1 kB 0 B
build/edit-widgets/style-rtl.css 2.81 kB 0 B
build/edit-widgets/style.css 2.81 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.4 kB 0 B
build/editor/style-rtl.css 3.83 kB 0 B
build/editor/style.css 3.82 kB 0 B
build/element/index.js 4.44 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.55 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@ellatrix ellatrix force-pushed the remove/native-props-for-web branch from 7ab7b58 to dec37e1 Compare September 29, 2020 13:27
@ZebulanStanphill ZebulanStanphill added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Package] Block editor /packages/block-editor [Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended labels Sep 29, 2020
@ellatrix ellatrix merged commit 363df9f into master Sep 29, 2020
@ellatrix ellatrix deleted the remove/native-props-for-web branch September 29, 2020 14:32
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Sep 29, 2020
@stokesman
Copy link
Contributor

stokesman commented Sep 29, 2020 •
edited
Loading

This seems to have busted the class name for at least the button block (I reverted 363df9f to check and my buttons were styled/classed again). I'm glad to see the console clean again though 👍

@ellatrix
Copy link
Member Author

ellatrix commented Sep 30, 2020

@stokesman What do you mean by busted?

@ellatrix
Copy link
Member Author

ellatrix commented Sep 30, 2020

I still see classes rendered for buttons

@stokesman

This comment has been minimized.

Sign in to view
@stokesman
Copy link
Contributor

stokesman commented Sep 30, 2020

I'm sorry about the bother. The issue resolved when I restarted npm run dev and it's something I'll be sure to try in the future.

@ellatrix
Copy link
Member Author

ellatrix commented Oct 5, 2020

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cameronvoell cameronvoell Awaiting requested review from cameronvoell

@etoledom etoledom Awaiting requested review from etoledom

@guarani guarani Awaiting requested review from guarani

Assignees

No one assigned

Labels

[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Package] Block editor /packages/block-editor [Package] Rich text /packages/rich-text [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@ellatrix @stokesman @ZebulanStanphill