Add a button to allow resetting the ComboboxControl value #25692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Feature] UI Components
youknowriad
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +156 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
youknowriad
commented
Sep 29, 2020
Contributor
Author
There was a problem hiding this comment.
This extra Flex was only needed to center the Button properly, I was wondering if FlexItems should automatically be flexes as well 🤔 cc @ItsJonQ
youknowriad
commented
Sep 29, 2020
Contributor
Author
There was a problem hiding this comment.
I hesitated between a "grow" prop or an "expand" one.
Contributor
There was a problem hiding this comment.
I prefer "grow" since it's already CSS/flex terminology.
youknowriad
force-pushed
the
add/allow-reset-combobox
branch
from
ec05e14 to
650d876
Compare
|
@youknowriad Haiii! So cool that you're using You can achieve what you need with <Flex>
<FlexBlock>Adaptively wide thing</FlexBlock>
<FlexItem>Tiny thing</FlexItem>
</Flex>The only thing I needed to adjust (css wise) was to change the Switching it to a block based HTML element Hope this helps!! |
ItsJonQ
reviewed
Sep 29, 2020
6 tasks
mcsf
approved these changes
Oct 8, 2020
|
Thanks @mcsf ! Looks like there's a snapshot test conflict. I'm going to resolve that and merge :) |
ItsJonQ
force-pushed
the
add/allow-reset-combobox
branch
from
41efdf5 to
359abb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the ComboboxControl in selects where "null" values are allowed like #25267 we need to be able to reset its value.
This PR does so by adding a reset button.
Testing instructions