Skip to content

InspectorAdvancedControls: Add README.md #25566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcsf merged 5 commits into from
Oct 13, 2020
Merged

InspectorAdvancedControls: Add README.md #25566

mcsf merged 5 commits into from
Oct 13, 2020

Conversation

@mcsf
Copy link
Contributor

@mcsf mcsf commented Sep 23, 2020 •
edited
Loading

Part of #22891

inspector-advanced-controls

Description

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@mcsf mcsf added the [Type] Developer Documentation Documentation for developers label Sep 23, 2020
@mcsf mcsf force-pushed the docs/add-inspector-advanced-controls-readme branch from 3e75bd6 to b2362d1 Compare September 23, 2020 14:47
@mcsf mcsf marked this pull request as ready for review September 23, 2020 14:48
@mcsf mcsf mentioned this pull request Sep 23, 2020
Closed
@github-actions
Copy link

github-actions bot commented Sep 23, 2020 •
edited
Loading

Size Change: +11.4 kB (0%)

Total Size: 1.19 MB

Filename Size Change
build/annotations/index.js 3.54 kB +18 B (0%)
build/blob/index.js 668 B +48 B (7%) 🔍
build/block-directory/index.js 8.55 kB -58 B (0%)
build/block-editor/index.js 129 kB -92 B (0%)
build/block-editor/style-rtl.css 10.9 kB -42 B (0%)
build/block-editor/style.css 10.9 kB -41 B (0%)
build/block-library/editor-rtl.css 8.65 kB +48 B (0%)
build/block-library/editor.css 8.65 kB +49 B (0%)
build/block-library/index.js 145 kB +9.83 kB (6%) 🔍
build/block-library/style-rtl.css 7.66 kB +3 B (0%)
build/block-library/style.css 7.65 kB +3 B (0%)
build/block-serialization-default-parser/index.js 1.78 kB +1 B
build/blocks/index.js 47.6 kB +53 B (0%)
build/components/index.js 169 kB +804 B (0%)
build/components/style-rtl.css 15.5 kB +108 B (0%)
build/components/style.css 15.5 kB +107 B (0%)
build/compose/index.js 9.43 kB +6 B (0%)
build/core-data/index.js 12 kB +9 B (0%)
build/data-controls/index.js 685 B -585 B (85%) 🏆
build/data/index.js 8.6 kB +189 B (2%)
build/date/index.js 31.9 kB +1 B
build/edit-navigation/index.js 10.6 kB -12 B (0%)
build/edit-post/index.js 306 kB +246 B (0%)
build/edit-post/style-rtl.css 6.29 kB +40 B (0%)
build/edit-post/style.css 6.28 kB +43 B (0%)
build/edit-site/index.js 21 kB +543 B (2%)
build/edit-site/style-rtl.css 3.73 kB -53 B (1%)
build/edit-site/style.css 3.73 kB -52 B (1%)
build/edit-widgets/index.js 21.2 kB +122 B (0%)
build/edit-widgets/style-rtl.css 3.02 kB +19 B (0%)
build/edit-widgets/style.css 3.02 kB +20 B (0%)
build/editor/index.js 45.5 kB +1 B
build/editor/style-rtl.css 3.85 kB +17 B (0%)
build/editor/style.css 3.84 kB +20 B (0%)
build/element/index.js 4.45 kB +6 B (0%)
build/escape-html/index.js 734 B +1 B
build/format-library/index.js 7.49 kB +1 B
build/is-shallow-equal/index.js 710 B +1 B
build/keyboard-shortcuts/index.js 2.39 kB -4 B (0%)
build/list-reusable-blocks/index.js 3.02 kB -3 B (0%)
build/media-utils/index.js 5.12 kB -1 B
build/nux/index.js 3.27 kB +1 B
build/priority-queue/index.js 790 B +1 B
build/redux-routine/index.js 2.85 kB -1 B
build/rich-text/index.js 13 kB -3 B (0%)
build/server-side-render/index.js 2.6 kB -1 B
build/shortcode/index.js 1.7 kB +2 B (0%)
build/url/index.js 4.06 kB +2 B (0%)
build/viewport/index.js 1.74 kB +2 B (0%)
build/warning/index.js 1.14 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

mkaz
mkaz previously requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you switch the ES5 and ESNext code tabs so ESNext is showed first?

Per documentation here, ESNext is more common and preferred syntax to default to.

@mcsf
Copy link
Contributor Author

mcsf commented Oct 9, 2020

Good point! Done in 18a9a78. /cc @mkaz

@mcsf mcsf requested a review from mkaz October 9, 2020 11:50
ntsekouras
ntsekouras approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@ntsekouras ntsekouras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@mcsf mcsf dismissed mkaz’s stale review October 13, 2020 11:31

Feedback addressed

@mcsf mcsf merged commit 8ad68f1 into master Oct 13, 2020
@mcsf mcsf deleted the docs/add-inspector-advanced-controls-readme branch October 13, 2020 11:31
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntsekouras ntsekouras ntsekouras approved these changes

@ellatrix ellatrix Awaiting requested review from ellatrix

@youknowriad youknowriad Awaiting requested review from youknowriad

@mkaz mkaz Awaiting requested review from mkaz

Assignees

No one assigned

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@mcsf @mkaz @ntsekouras