Gallery: Add a margin declarion #25291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ZebulanStanphill
added
[Feature] Themes
kjellr
approved these changes
Oct 2, 2020
Contributor
kjellr
left a comment
kjellr
left a comment
There was a problem hiding this comment.
This makes sense as a precaution. I tested on a handful of themes, and didn't notice any negative effects. 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some themes declare margins on
figcaption. We should explicitly declare the margin on the gallery figcaption to zero so that themes can't override it.How has this been tested?
Varia based themes include an override to prevent the theme leaking into the block, but we can handle this in the block directly.
Screenshots
Without this line:
With this line:
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: