[edit-widgets] Test for storing raw html in widgets #24886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
added
the
[Feature] Widgets Screen
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
Member
|
The GitHub Actions failure is very odd. Maybe try rebasing this? |
noisysocks
force-pushed
the
update/test-unfiltered-html
branch
from
b78ebb3 to
7a07596
Compare
Contributor
Author
|
@noisysocks all tests passed - now quick! Review before the CI reports more failures :-) |
noisysocks
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more test to ensure that only superadmin is universally able to store HTML in widgets using the new API endpoint. Admins should only be able to do so on regular sites (not multisites).
This PR tests based on roles, it would be much nicer to test based on capabilities - I didn't quite figure it yet and I'll be away for the next two weeks, but follow-up PRs are welcome!