Block Editor: use optional chaining and nullish coalescing instead of Lodash.get. #23632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZebulanStanphill
added
[Type] Code Quality
|
Size Change: +87 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
ZebulanStanphill
force-pushed
the
polish/remove-lodash-get-from-block-editor
branch
4 times, most recently
from
a3d1cf9 to
7a19d11
Compare
ZebulanStanphill
force-pushed
the
polish/remove-lodash-get-from-block-editor
branch
from
7a19d11 to
7f257fa
Compare
ZebulanStanphill
force-pushed
the
polish/remove-lodash-get-from-block-editor
branch
from
7f257fa to
6e4688d
Compare
youknowriad
approved these changes
Sep 28, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I find these refactorings a bit useless tbh but 🤷♂️
| [ 'onChange' ], | ||
| null | ||
| ), | ||
| preferredStyle: preferredStyleVariations?.value?.[ blockName ], |
Contributor
There was a problem hiding this comment.
In this instance, I find the previous implementation a lot more clear.
Member
Author
There was a problem hiding this comment.
I dunno, it seems clearer to me. 🤔
ZebulanStanphill
deleted the
polish/remove-lodash-get-from-block-editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title. Optional chaining and nullish coalescing are (recent) standard JS features that we already use across our codebase, so this PR helps increase consistency by updating cases where we were using Lodash.get. The native JS syntax is also a lot easier to comprehend, in my opinion.
Since there are a lot of places where
_.getis being used right now, I'm doing this one package at a time, to make it easier to review.It's worth noting there are a few cases where using
_.getactually does make sense: cases where the object path has a dynamic level of nesting, which as far as I am aware, cannot be expressed using optional chaining. Those cases have been left unchanged.This is part of a series of code quality PRs I am working on. The long-term goal is to reduce
lodashusage in cases where a standard JS function/syntax works just as well or better, which should reduce our packages' bundle sizes for 3rd parties using them. This will also increase clarity by making nullish value handling more explicit (Lodash often silently ignores nullish values) and avoiding the use of external libraries when simple equivalents exist in standard JS.