More accurate dependency list for useGenericPreviewBlock hook#22355
Merged
More accurate dependency list for useGenericPreviewBlock hook#22355
Conversation
adamziel
added
[Feature] Inspector Controls
6 tasks
|
Size Change: +5 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
draganescu
approved these changes
May 15, 2020
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Works as described in the test set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #21993 where the dependencies list was slightly off. Namely,
useMemo()is always recomputed when theblockargument changes, even if we only useblock.name. This PR fixes that.How has this been tested?
Tested locally with the same test plan as in #21973
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: