Fix conflict with Jetpack plugin when loading the core/freeform block#2229
Merged
Fix conflict with Jetpack plugin when loading the core/freeform block#2229
core/freeform block#2229Conversation
nylen
added
[Status] In Progress
nylen
force-pushed
the
fix/jetpack-grunion-conflict
branch
from
03e8c92 to
6092b28
Compare
ellatrix
approved these changes
Aug 4, 2017
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Sounds good as a very temporary fix.
Member
Author
|
I saw a couple of different manifestations of this error when testing. Here's one; the other was a fully white screen:
This PR fixes both cases. It's currently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading the
core/freeformblock with Jetpack enabled, this line throws an error and causes a white screen. See Automattic/jetpack#7490.This PR works around the issue by unhooking the problematic script when loading Gutenberg.
The next version of Jetpack (5.2.2) should contain a fix for this; we should also try to catch errors like this as (sort of) described in #1743.