Conversation
adamziel
changed the base branch from
master
to
add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector
|
Size Change: +100 B (0%) Total Size: 833 kB
ℹ️ View Unchanged
|
6 tasks
adamziel
changed the base branch from
add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector
to
master
adamziel
force-pushed
the
add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill
branch
from
0d3ea95 to
d0da2af
Compare
adamziel
requested review from
Soean,
ajitbohra and
jorgefilipecosta
as code owners
adamziel
force-pushed
the
add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill
branch
from
d0da2af to
ea92918
Compare
talldan
reviewed
May 12, 2020
Contributor
|
I tested this and it works all right, the performance in the editor is good even with larger menus. |
draganescu
reviewed
May 14, 2020
adamziel
force-pushed
the
add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill
branch
from
ea92918 to
1854fa0
Compare
Contributor
Author
|
@draganescu would you mind approving if it works well? :-) |
draganescu
approved these changes
May 18, 2020
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Forgot to approve! Here you go @adamziel 
adamziel
deleted the
add/navigation-menu-block/allow-editing-of-new-menu-items-from-the-block-inspector-fill
branch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #21948
Fixes #20748.
It plugs RichText editor into those slots
navigation-link/edit.js. As a result, it's possible to edit the label from theBlockNavigationListitself.How has this been tested?
On experimental nav-menus page:
Go to
/wp-admin/admin.php?page=gutenberg-navigationEdit the text from the navigation structure panel like on the gif below:
Try with both top-level and nested navigation items
In posts editor:
Make sure to use rich formatting like pressing enter or using keyboard shortcuts (e.g. cmd+b on mac to bold selected text).
Try editing titles through the navigator in modal:
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: