Eriktdesign add/tags in latest posts block#20785
Closed
draganescu wants to merge 2 commits intomasterfrom
Closed
Conversation
draganescu
requested review from
Soean,
ajitbohra,
chrisvanpatten,
jorgefilipecosta,
talldan and
youknowriad
as code owners
|
Size Change: +687 B (0%) Total Size: 857 kB
ℹ️ View Unchanged
|
draganescu
force-pushed
the
eriktdesign-add/tags-in-latest-posts-block
branch
from
7488070 to
f995e0c
Compare
Contributor
Author
|
I updated this but currently have some glitching behavior when tags are added:
|
Contributor
Author
|
There are also a design issue that should be solved for this PR:
a) nothing happens and ENTER key makes my text disappear (current behavior) I will implement b) but a sort of mock-up as to where should I display that message would be good. |
draganescu
force-pushed
the
eriktdesign-add/tags-in-latest-posts-block
branch
from
7377e3a to
0dfe1b0
Compare
|
Using Gutenberg.run, I added some posts via XML, then added the Latest Posts block to another post. The block showed the latest 5 posts by default and when a tag is added to the input element in the inspector controls, the block refreshes with newly polled data according to the new criteria.
|
Contributor
Author
|
Closed b/c of lack of traction and the upcoming Query block's replacing the LP block. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS!
Description
Props @eriktdesign, this is a refresh of #19755
Moves #13027 forward by adding filtering by tags.
How has this been tested?
Tested locally.
LatestPostsblockScreenshots
Types of changes
Non breaking addition to
LatestPostsandQuerySelectorChecklist: