Fix: Styling problem on vertically aligned blocks#20368
Merged
jorgefilipecosta merged 1 commit intomasterfrom Feb 24, 2020
Merged
Fix: Styling problem on vertically aligned blocks#20368jorgefilipecosta merged 1 commit intomasterfrom
jorgefilipecosta merged 1 commit intomasterfrom
Conversation
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
requested review from
Soean,
ajitbohra and
talldan
as code owners
|
Size Change: +27 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
Contributor
|
In my quick test, this does appear to work as intended with no side-effects. Nice work! 👍 👍 |
jorgefilipecosta
deleted the
fix/style-problem-on-vertically-aligned-columns
branch
jorgefilipecosta
added a commit
that referenced
this pull request
Feb 24, 2020
jorgefilipecosta
added a commit
that referenced
this pull request
Feb 24, 2020
Member
|
I'm a bit confused what impact I might also be a little concerned how well an explicit |
Contributor
|
If it is of any use, another side-effect of NOT adding
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #19962
Props to @mrleemon for suggesting this fix.
Some blocks did not work inside the columns block, this PR adds a CSS fix for the issue.
In my tests, the fix does not seem to have unexpected consequences.
cc: @aduth, @jasmussen, @getdave I would appreciate if you could double-check if this fix works as expected.
How has this been tested?
I added a columns block with two columns.
I added the Image Slider Block from the "Ultimate Blocks" plugin inside with some images inside the first column.
I added sample text on the second column making the height of the second column higher than the one of the first column.
I vertically aligned the columns to the three possible values and verified for each alignment the result looked correct. (On master the slider is broken).