Skip to content

API: Stabilize localAutosave() as autosave( { local: true } ) #20149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mcsf merged 2 commits into from
Oct 12, 2020
Merged

API: Stabilize localAutosave() as autosave( { local: true } ) #20149

mcsf merged 2 commits into from
Oct 12, 2020

Conversation

@mcsf
Copy link
Contributor

@mcsf mcsf commented Feb 10, 2020

Description

Part of #20116. See #20116 (comment).

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@mcsf mcsf added [Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Saving Related to saving functionality labels Feb 10, 2020
@jorgefilipecosta jorgefilipecosta mentioned this pull request Feb 10, 2020
Closed
18 tasks
aduth
aduth approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an imperative verb (as conventional for action creators), "local autosave" is perhaps a bit awkward/forced, but I think it can work.

@mcsf
Copy link
Contributor Author

mcsf commented Feb 10, 2020

As an imperative verb (as conventional for action creators), "local autosave" is perhaps a bit awkward/forced, but I think it can work.

I had the same feeling. :) I wondered about doLocalAutosave, locallyAutosave. Thoughts?

@aduth
Copy link
Member

aduth commented Feb 10, 2020 •
edited
Loading

Had there been any prior consideration to make this an option of the existing autosave action creator?

e.g.

autosave( { local: true } );

It doesn't seem to me as a fundamentally different operation. And, as a bonus, it helps avoid answering this question of naming 😄 Perhaps our naming convention serves us well here in highlighting the pain point, where a qualifier to an operation should instead be integrated as an option of the action named using the base verb.

@mcsf
Copy link
Contributor Author

mcsf commented Feb 10, 2020

Had there been any prior consideration to make this an option of the existing autosave action creator?

I don't recall, but I don't dislike it.

@mtias
Copy link
Member

mtias commented Feb 10, 2020

I like it.

@ellatrix
Copy link
Member

ellatrix commented Jun 6, 2020

Can this be merged?

@youknowriad
Copy link
Contributor

youknowriad commented Oct 1, 2020

What's remaining here?

@mcsf
Copy link
Contributor Author

mcsf commented Oct 1, 2020

Can this be merged?

What's remaining here?

I can refresh the branch and switch localAutosave to autosave( { local: true } ), as Andrew suggested. Anyone opposed?

@mcsf mcsf force-pushed the update/stabilize-local-autosave branch from b72de73 to 5a563ea Compare October 2, 2020 00:14
@github-actions
Copy link

github-actions bot commented Oct 2, 2020 •
edited
Loading

Size Change: +35 B (0%)

Total Size: 1.19 MB

Filename Size Change
build/editor/index.js 45.5 kB +35 B (0%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.55 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 129 kB 0 B
build/block-editor/style-rtl.css 10.9 kB 0 B
build/block-editor/style.css 10.9 kB 0 B
build/block-library/editor-rtl.css 8.65 kB 0 B
build/block-library/editor.css 8.65 kB 0 B
build/block-library/index.js 145 kB 0 B
build/block-library/style-rtl.css 7.66 kB 0 B
build/block-library/style.css 7.65 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 169 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.43 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 685 B 0 B
build/data/index.js 8.6 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.29 kB 0 B
build/edit-post/style.css 6.28 kB 0 B
build/edit-site/index.js 21 kB 0 B
build/edit-site/style-rtl.css 3.73 kB 0 B
build/edit-site/style.css 3.73 kB 0 B
build/edit-widgets/index.js 21.2 kB 0 B
build/edit-widgets/style-rtl.css 3.02 kB 0 B
build/edit-widgets/style.css 3.02 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 734 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 790 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.6 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@mcsf mcsf force-pushed the update/stabilize-local-autosave branch from 5a563ea to 3f36c10 Compare October 2, 2020 17:02
@mcsf mcsf force-pushed the update/stabilize-local-autosave branch from 3f36c10 to 1e1a9f0 Compare October 9, 2020 11:59
@mcsf
Copy link
Contributor Author

mcsf commented Oct 9, 2020

@ellatrix or @youknowriad: can you give it a last review, for good measure? 🙏

@mcsf mcsf changed the title API: Stabilize localAutosave() API: Stabilize localAutosave() as autosave( { local: true } ) Oct 9, 2020
youknowriad
youknowriad approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@youknowriad youknowriad added the [Type] New API New API to be used by plugin developers or package users. label Oct 12, 2020
@mcsf mcsf merged commit d4a74cc into master Oct 12, 2020
@mcsf mcsf deleted the update/stabilize-local-autosave branch October 12, 2020 11:20
@github-actions github-actions bot added this to the Gutenberg 9.2 milestone Oct 12, 2020
@jsnajdr jsnajdr mentioned this pull request Oct 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowriad youknowriad youknowriad approved these changes

@aduth aduth aduth approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@mkaz mkaz Awaiting requested review from mkaz

@nerrad nerrad Awaiting requested review from nerrad

@ntwb ntwb Awaiting requested review from ntwb

@talldan talldan Awaiting requested review from talldan

Assignees

No one assigned

Labels

[Feature] Extensibility The ability to extend blocks or the editing experience [Feature] Saving Related to saving functionality [Type] New API New API to be used by plugin developers or package users.

Projects

None yet

Milestone

Gutenberg 9.2

Development

Successfully merging this pull request may close these issues.

6 participants

@mcsf @aduth @mtias @ellatrix @youknowriad