Block Library: Add a Post Tags block.#19580
Merged
Conversation
epiqueras
requested review from
Soean,
TimothyBJacobs,
ajitbohra,
jorgefilipecosta and
talldan
as code owners
youknowriad
reviewed
Jan 13, 2020
| <a key={ tagId } href={ tag.link }> | ||
| { tag.name } | ||
| </a> | ||
| ); |
Contributor
There was a problem hiding this comment.
I believe ultimately, we could offer a way to add/remove tags directly here. Let's land a readonly block first though.
youknowriad
reviewed
Jan 13, 2020
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Added "design feedback" tag for designers to start thinking about the potential of these blocks (style variations, styling...)
Contributor
|
I noticed this error while inserting the block (post without tags). Also, how does it behave if the CPT doesn't support tags? |
youknowriad
reviewed
Jan 13, 2020
|
|
||
| export default function PostTagsEdit() { | ||
| if ( ! useEntityId( 'postType', 'post' ) ) { | ||
| return 'Post Tags Placeholder'; |
Contributor
Author
Fixed.
It won't render anything. |
9 tasks
Member
|
High level thought: should the block be called |
Contributor
Author
|
That makes more sense now that we have variations. |
Contributor
Author
|
Can we merge this scaffold to avoid more merge conflicts in the shared files? |
ockham
force-pushed
the
add/post-tags-block
branch
from
f4d9750 to
abc53bc
Compare
Contributor
|
Rebased. |
|
Size Change: +222 B (0%) Total Size: 864 kB
ℹ️ View Unchanged
|
ockham
reviewed
Feb 24, 2020
ockham
reviewed
Feb 24, 2020
ockham
reviewed
Feb 24, 2020
ockham
approved these changes
Feb 24, 2020
Contributor
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
Left a few minor notes and one question, but overall good to merge 👍
mtias
reviewed
Feb 24, 2020
| if ( ! empty( $post_tags ) ) { | ||
| $output = ''; | ||
| foreach ( $post_tags as $tag ) { | ||
| $output .= '<a href="' . get_tag_link( $tag->term_id ) . '">' . $tag->name . '</a>' . ' | '; |
Member
There was a problem hiding this comment.
We should get to a point where we support the common customization the theme function tags offer: https://codex.wordpress.org/Function_Reference/the_tags
6 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Post Tags block akin to the Post Title and Post Content blocks.
How has this been tested?
Types of Changes
New Feature: There is a new Post Tags block for template building.
Checklist: