Skip to content

Update re-resizable dependency#17011

Merged
nerrad merged 2 commits intomasterfrom
update/re-resizable
Aug 13, 2019
Merged

Update re-resizable dependency#17011
nerrad merged 2 commits intomasterfrom
update/re-resizable

Conversation

@swissspidy
Copy link
Copy Markdown
Member

@swissspidy swissspidy commented Aug 12, 2019

Description

Fixes #16950 after the upstream library was updated.

How has this been tested?

Not tested yet.

Screenshots

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@swissspidy swissspidy requested a review from nerrad August 12, 2019 14:22
@gziolo gziolo added the [Package] Components /packages/components label Aug 12, 2019
@nerrad
Copy link
Copy Markdown
Contributor

nerrad commented Aug 12, 2019

If this gets tested and merged before I get a chance to do that (which will be absolutely okay if that happens 😄 ) we should let the author of the package know it fixed things for us too: bokuweb/re-resizable#504

@gziolo
Copy link
Copy Markdown
Member

gziolo commented Aug 12, 2019

I think we should include a note in the changelog of @wordpress/components package. Some similar entries can be found in:
https://github.com/WordPress/gutenberg/blob/master/packages/scripts/CHANGELOG.md

The bundled eslint dependency has been updated from requiring ^5.16.0 to requiring ^6.1.0.

@swissspidy
Copy link
Copy Markdown
Member Author

swissspidy commented Aug 12, 2019

I think we should include a note in the changelog of @wordpress/components package.

Done!

nerrad
nerrad approved these changes Aug 13, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@nerrad nerrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed this fixes the error and components using resizable are working as expected. Thanks for getting this updated @swissspidy !

@nerrad nerrad merged commit 30482db into master Aug 13, 2019
@ntwb ntwb deleted the update/re-resizable branch August 13, 2019 01:26
@senadir senadir added this to the Gutenberg 6.4 milestone Aug 25, 2019
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@swissspidy @gziolo
Update re-resizable dependency (#17011)
acef0b8 
* Update re-resizable dependency

* Add changelog entry
gziolo pushed a commit that referenced this pull request Aug 29, 2019
@swissspidy @gziolo
Update re-resizable dependency (#17011)
eeb213a 
* Update re-resizable dependency

* Add changelog entry
@spacedmonkey spacedmonkey mentioned this pull request Sep 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nerrad nerrad nerrad approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

No one assigned

Labels

[Package] Components /packages/components

Projects

None yet

Milestone

Gutenberg 6.4

Development

Successfully merging this pull request may close these issues.

Fix deprecated componentWillReceiveProps lifecycle method usage in ResizableBox component

4 participants

@swissspidy @nerrad @gziolo @senadir