Core Data: Add util for minimally modifying items.#16823
Merged
Conversation
youknowriad
approved these changes
Jul 30, 2019
Contributor
Author
I opted not to, because then we would be doing what the editor store already does and hamper performance unnecessarily. |
epiqueras
force-pushed
the
add/core-data-util-for-minimally-modifying-items
branch
from
340f616 to
2cc458d
Compare
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
gziolo
pushed a commit
that referenced
this pull request
Aug 29, 2019
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #16761
Description
This PR adds a utility for minimally modifying items, to the core data package in preparation for refactoring the editor store to rely entirely on
core/dataentities. The utility maps an item to a new item, retaining non primitive value references where possible (where deeply equal). This is necessary so that components that depend on these values don't update unnecessarily.How has this been tested?
Unit tests were written and ran to test for expected functionality.
Checklist: