Skip to content

Latest post block iteration: featured image add.#16448

Closed
v9ai wants to merge 3 commits intomasterfrom
featured-image-latest-posts
Closed

Latest post block iteration: featured image add.#16448
v9ai wants to merge 3 commits intomasterfrom
featured-image-latest-posts

Conversation

@v9ai
Copy link
Copy Markdown
Member

@v9ai v9ai commented Jul 7, 2019

Description

Fixes: #1594

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@v9ai v9ai added [Feature] Blocks Overall functionality of blocks [Block] Latest Posts Affects the Latest Posts Block labels Jul 7, 2019
@v9ai v9ai added this to the WordPress 5.x milestone Jul 7, 2019
@v9ai v9ai self-assigned this Jul 7, 2019
@v9ai
Copy link
Copy Markdown
Member Author

v9ai commented Jul 7, 2019 •
edited
Loading

Have reused some logic as suggested by @gziolo from @ajitbohra's closed WIP PR.

Soean
Soean requested changes Jul 7, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@Soean Soean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. You also have to add this feature to the PHP file, otherwise the image will not be rendered on the frontend.

@v9ai v9ai changed the title Latest post block iteration: featured image add. WIP: Latest post block iteration: featured image add. Jul 8, 2019
@v9ai
Copy link
Copy Markdown
Member Author

v9ai commented Jul 8, 2019

Thanks for the PR. You also have to add this feature to the PHP file, otherwise the image will not be rendered on the frontend.

Sure, this will be the next focus, now this PR is still a WIP.

@paaljoachim paaljoachim mentioned this pull request Aug 25, 2019
Merged
3 tasks
@paaljoachim
Copy link
Copy Markdown
Contributor

paaljoachim commented Nov 2, 2019

Hi @NicolaD

Can we get a status update on where this PR is at the moment?
Thanks.

@v9ai v9ai changed the title WIP: Latest post block iteration: featured image add. Latest post block iteration: featured image add. Nov 3, 2019
@v9ai v9ai requested a review from Soean November 3, 2019 14:40
@v9ai
Copy link
Copy Markdown
Member Author

v9ai commented Nov 3, 2019

Hi @NicolaD

Can we get a status update on where this PR is at the moment?
Thanks.

Hey @paaljoachim
It's ready for review now.
Thanks for chiming in 👍

@v9ai v9ai requested a review from a team November 3, 2019 14:41
@youknowriad youknowriad added the Needs Design Feedback Needs general design feedback. label Nov 11, 2019
@melchoyce
Copy link
Copy Markdown
Contributor

melchoyce commented Nov 11, 2019

Hey, have y'all also seen #17151?

@paaljoachim
Copy link
Copy Markdown
Contributor

paaljoachim commented Nov 12, 2019 •
edited
Loading

I noticed that Riad checked out the other Latest Post Block: featured image feature. So I believe what is important here is just comparing both and figuring out where to take it from there.
@youknowriad

@mapk
Copy link
Copy Markdown
Contributor

mapk commented Nov 21, 2019

I was able to test this briefly, but after making a couple settings changes in the block's settings like number of posts... I am now continually getting this error.

Screen Shot 2019-11-20 at 5 36 46 PM

I delete the block and try readding it, but keep getting the same error. I've even tried on different posts, etc., but same error.

@mcsf mcsf added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 16, 2019
@mapk
Copy link
Copy Markdown
Contributor

mapk commented Jan 30, 2020

Because this appears to be stale, I've removed it from the 5.4 project board and going with #17151 instead. Because there is active work on the other one, let's close this as well.

@mapk mapk closed this Jan 30, 2020
@youknowriad youknowriad deleted the featured-image-latest-posts branch January 30, 2020 08:13
@v9ai v9ai added the [Status] Not Implemented Issue/PR we will (likely) not implement. label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth Awaiting requested review from aduth

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@gziolo gziolo Awaiting requested review from gziolo

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@nerrad nerrad Awaiting requested review from nerrad

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

@Soean Soean Awaiting requested review from Soean

@mapk mapk Awaiting requested review from mapk

@melchoyce melchoyce Awaiting requested review from melchoyce

Assignees

@v9ai v9ai

Labels

[Block] Latest Posts Affects the Latest Posts Block [Feature] Blocks Overall functionality of blocks Needs Design Feedback Needs general design feedback. [Status] Not Implemented Issue/PR we will (likely) not implement. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed.

Projects

None yet

Milestone

WordPress 5.x

Development

Successfully merging this pull request may close these issues.

Iterations on "Latest Posts" Block

7 participants

@v9ai @paaljoachim @melchoyce @mapk @Soean @mcsf @youknowriad