Remove background color from heading#15814
Merged
jorgefilipecosta merged 1 commit intomasterfrom May 24, 2019
Merged
Conversation
jorgefilipecosta
requested review from
Soean,
ajitbohra,
gziolo,
notnownikki,
talldan and
youknowriad
as code owners
jorgefilipecosta
changed the title
This reverts commit 22ab406.
jorgefilipecosta
force-pushed
the
revert-15625-add/color-options-to-heading-block
branch
from
2bfdade to
942e7ed
Compare
youknowriad
approved these changes
May 24, 2019
jorgefilipecosta
deleted the
revert-15625-add/color-options-to-heading-block
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some discussions, it was decided that for now only the text color option should be available.
How has this been tested?
I verified the background color functionality was removed from the heading block, and the block still works as expected.