Conversation
- Reorder: img goes first than the inline menu items - Always render the inline menu items. We want to keep a consistent tabbable experience. We'll style them down when not in focus.
We can't use the isSelected property to conditionally render them, otherwise they won't be tabbed through when tabbing backwards.
The GalleryImage gets selected by focusing on the caption (tabbing backwards) and the <img> element (tabbing forwards). At that time, the button is enabled, and will get the focus.
oandregal
requested review from
Soean,
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
talldan and
youknowriad
as code owners
oandregal
added
[a11y] Keyboard & Focus
[Block] Gallery
Member
Author
|
Note that the caption's toolbar is part of the tab stops when tabbing backward but not forward. Making it work identical for both cases would require the caption's toolbar to always be visible for the selected GalleryImage, not only when the caption is selected. |
jasmussen
approved these changes
May 10, 2019
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Yep, perfect, thanks so much:
Code looks good to me too. But I would appreciate you get a sanity check on the code from someone else as well.
youknowriad
approved these changes
May 10, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
There are still inconsistencies related to the toolbar but this is a huge improvement over what we have.
priethor
added
the
[Focus] Accessibility (a11y)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14814
Previous attempt: #14931
This PR fixes the keyboard tab order for navigating through gallery items:
Forward:
Backward:
There is a related issue #14823 for deselecting the image when it is the first/last after it losses focus. This will be fixed separately.