adds new edit flow to the video block#15516
Conversation
draganescu
requested review from
Soean,
ajitbohra,
gziolo,
jorgefilipecosta,
noisysocks,
notnownikki,
talldan and
youknowriad
as code owners
kjellr
added
[Block] Video
kjellr
left a comment
kjellr
left a comment
There was a problem hiding this comment.
From a design perspective, this is all set!
Should get a code review before merge. 👍
gziolo
added
the
Good First Review
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
I left some minor comments. The code seems ready after the minor changes are addressed 👍
draganescu
force-pushed
the
update/new-edit-flow-video
branch
from
e932929 to
147513f
Compare
|
@jorgefilipecosta I have updated the code as per review and also rebased. Let me know if I understood your comments properly :) |
|
I'm not sure if this is solely related to the Video block because I haven't tested it with others yet, but there's a bug when transforming the Video block to a Media+Text block and then back again to a VIdeo block. The Expected behavior: Icons in the toolbar should remain in the same position for each block.
|
|
@mapk see this comment on the same issue on the embed block. I will treat it in a separate issue. |
afercia
added
the
[Focus] Accessibility (a11y)
|
Related to the "swapping" icon: #16048 |
|
#11952 changed direction so closing this as it became irrelevant. |
6 participants
Description
Closes #14795
This is a follow up to the image block edit flow update which ports the new flow to all the blocks which have media with an edit state.
How has this been tested?
For now I've only tested locally.
Types of change
New feature (non-breaking change which adds functionality)
Screenshots