Skip to content

Framework: Remove SCSS entry from CODEOWNERS#15216

Merged
aduth merged 1 commit intomasterfrom
remove/codeowners-scss
Apr 29, 2019
Merged

Framework: Remove SCSS entry from CODEOWNERS#15216
aduth merged 1 commit intomasterfrom
remove/codeowners-scss

Conversation

@aduth
Copy link
Copy Markdown
Member

@aduth aduth commented Apr 26, 2019

Previously: #14062 (comment)

This pull request seeks to remove the *.scss entry from the CODEOWNERS file.

The behavior of CODEOWNERS is such that the last match will take precedence:

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
*.js    @js-owner

https://help.github.com/en/articles/about-code-owners#codeowners-syntax

The proposed benefit of removing this entry is:

  • Avoid overburdening a small set of individuals
  • Ensure to notify those who are otherwise marked as code owners for the given file placement

Testing Instructions:

This is a repository metadata file. There is no impact on the application.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants