Retry failing embeds with trailing slash#14705
Merged
notnownikki merged 2 commits intomasterfrom Mar 29, 2019
Merged
Conversation
notnownikki
requested review from
Soean,
aduth,
ajitbohra,
gziolo,
jorgefilipecosta,
nerrad,
noisysocks,
ntwb,
talldan and
youknowriad
as code owners
5 tasks
gziolo
added
[Block] Embed
gziolo
approved these changes
Mar 29, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Awesome teamwork @gbroques and @notnownikki. Let's get this in 🚢
Member
Author
|
Merged! I have noticed that the "can't embed this" message does flash up very briefly before previews are fetched, so the condition described at #14600 (comment) does have a visual effect that is never used to. I'm not sure when that started, but I'll put that on my list to look at when I make the |
This was referenced Apr 1, 2019
ellatrix
pushed a commit
that referenced
this pull request
Apr 3, 2019
* Fix embedding Twitter URLs with a trailing slash (Closes #12664) * Fix race condition for WordPress URLs that end in slashes, add test
ellatrix
added a commit
that referenced
this pull request
Apr 4, 2019
* RichText: improve format boundary style (#14519) * RichText: improve format boundary style * rgb => rgba * Paste: check plain text for gutenberg content (#14536) * Make ClipboardButton inside a block work correctly in Safari (#7106) * Make ClipboardButton inside a block work in Safari * Update changelogs * Block Editor: Update "Next" to "Unreleased" per guidelines https://github.com/WordPress/gutenberg/blob/master/packages/README.md#maintaining-changelogs * Input Interaction: always expand single line selection vertically (#14487) * Input Interaction: always expand single line selection vertically * Add e2e test * Use MenuItem instead of IconButton (#14569) * Remove id, infoid, label and aria-describedby from MenuItem (#14423) * Preformatted: save line breaks as characters (#14653) * Preformatted: save line breaks as characters * Update e2e test * Remove negative toolbar position rules from full-aligned blocks. (#14669) * Fix issue with double scrollbar in Fullscreen Mode (#14677) This PR fixes an issue where the sidebar would have two scrollbars when in fullscreen mode. * Fix WordPress embed block resolution (#14658) * Retry failing embeds with trailing slash (#14705) * Fix embedding Twitter URLs with a trailing slash (Closes #12664) * Fix race condition for WordPress URLs that end in slashes, add test * API Fetch: Fix error on empty OPTIONS preload data (#14714) * Input Interaction: better horizontal edge detection (#14462) * Input Interaction: better horizontal edge detection * Correct BR ranges * Add e2e test * Increase buffer for Firefox * Clean up * Merge isEdge logic * Fix typo * Address feedback * Build docs * Fix memize option key typo (#14750) * RichText: unify active formats, 'selectedFormat' and 'placeholderFormat' (#14411) * RichText: unify active formats, 'selectedFormat' and 'placeholderFormat' * Add extra e2e test * Only should boundary style when focused * Update docs * Try to trigger tests with Travis * Restore Travis config
This was referenced Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #12664.
Based on #14600.
When a URL can't be embedded, and it has a trailing slash, this resubmits without the trailing slash, so catch cases where people put trailing slashes at the end of twitter URLs, for example.
How has this been tested?
Types of changes
New feature
Checklist: