Data: Avoid unsetting insertUsage preference in block editor migration#14691
Merged
Data: Avoid unsetting insertUsage preference in block editor migration#14691
Conversation
aduth
added
[Type] Bug
This was referenced Mar 28, 2019
youknowriad
approved these changes
Mar 29, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Looks like there's an eslint issue, but approving as it would be good to include in the next release and backport to WP 5.2
Member
|
@youknowriad - how about 8b796e9? It should fix the issue. |
gziolo
approved these changes
Mar 29, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Well, we can polish later, let's merge it and re-test in master branch :)
This was referenced Apr 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14580
This pull request seeks to remove logic which would unset the
insertUsagepreference when migrating preferences to theblock-editormodule introduced in #13088 . This intends to resolve an issue where downgrading to an earlier version or deactivating the plugin could result in an editor crash due to the missing property.Testing instructions:
localStorage.clear()in your Developer Tools ConsoleinsertUsagepreference incore/editor.