Remove invalid url's and id's from media fixtures #14625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
ntwb,
talldan and
youknowriad
as code owners
jorgefilipecosta
force-pushed
the
fix/media-fixtures-so-they-can-be-used-in-end2end-tests
branch
from
4455244 to
17ac886
Compare
jorgefilipecosta
force-pushed
the
fix/media-fixtures-so-they-can-be-used-in-end2end-tests
branch
from
17ac886 to
2f2d3d6
Compare
gziolo
added
the
[Type] Automated Testing
gziolo
reviewed
Mar 28, 2019
| ) | ||
| ) | ||
| ); | ||
| const fileBasenames = getAvailableBlockFixturesBasenames(); |
Member
There was a problem hiding this comment.
How about you update the failing test (https://travis-ci.com/WordPress/gutenberg/jobs/187619473#L1011):
Block transforms › should contain the expected transforms
to perform more relaxed check using toMatchObject:
expect(
transforms
). toMatchObject( EXPECTED_TRANSFORMS );
Member
There was a problem hiding this comment.
I tried this locally and it seems to work:
it( 'example', () => {
const actual = {
core__gallery__columns: {
availableTransforms: [
'Slideshow',
'Image',
],
originalBlock: 'Gallery',
},
};
const expected = {
core__gallery__columns: {
availableTransforms: expect.arrayContaining( [
'Image',
] ),
originalBlock: 'Gallery',
},
};
expect( actual ).toMatchObject( expected );
} );
jorgefilipecosta
force-pushed
the
fix/media-fixtures-so-they-can-be-used-in-end2end-tests
branch
from
2f2d3d6 to
1e39d49
Compare
… the generic transforms test.
jorgefilipecosta
force-pushed
the
fix/media-fixtures-so-they-can-be-used-in-end2end-tests
branch
from
1e39d49 to
dec1e40
Compare
gziolo
approved these changes
Apr 3, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
I reviewed it the other day. Now that it is rebased with the latest fix merged to allow us to skip tests when 3rd party plugins are installed, this should be good to go 👍
| const maybeDescribe = process.env.POPULAR_PLUGINS ? | ||
| describe : | ||
| describe.skip; | ||
| describe.skip : |
gziolo
deleted the
fix/media-fixtures-so-they-can-be-used-in-end2end-tests
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes invalid URLs and ID's from the fixtures of media blocks making sure we can use these fixtures in the block transforms test case.
A temporary solution to not execute the transforms test cases for these blocks was removed.
Depends on: #14632
How has this been tested?
Verify the end 2 end tests pass.
Verify the fixture test cases pass
npm run test-unit test/integration/full-content/full-content.spec.js.