Merge mobile development branch into master (v2)#14503
Merged
Conversation
* RichText: only ignore input types that insert HTML * Mark RichTextInputEvent as unstable * Use Set
…eters returned onChange, and we forgot to update the PostTitle component (#13967)
Upload media progress bar is missing while media is uploading new
* Trigger onFocusStatusChange from PostTitle * Fix lint issue * Update post title shadow mechanism Also open inner ref so that focus state can be updated when focus is made programmatically * Update props * Update onRef as ref * Update title padding&margin
* Changed upload media icon color * Changed media placeholder background color
* Fix unexpected token in native code * Dummy commit to trigger Travis * Include the rnmobile release branch to Travis builds
* Mobile: Replaced Links UI with bottom-sheet component * Mobile links UI: Removed commented code. * Mobile: Fix lint issues * Mobile Links UI: Remove autofocus on Android. This hides an issue where the modal sometimes will be under the keyboard on Android.
* Remove title vertical paddings for Android * Revert "Remove title vertical paddings for Android" This reverts commit 09f0d35. * Import padding variables
* Make richText height changes contained to the rich text block. * Remove commented out code. * Remove aztec height from state. * Allow minHeight to be optional. * Remove minHeight from postTitle. * Remove minHeight on heading block.
* Fixes pasting in heading blocks. * Fixed an issue with a missing constant. * Removes some code that was added back as part of a merge conflict. * Re-adds some code removed by mistake.
* RNMobile: Adding original versin of keyboard-avoiding-view (to be modified) * Modified keyboard-avoiding-view to work well with bottom-sheets.
* Mobile Links UI: Avoid creating link with empty url field * Mobile Links UI: Using URL Keyboard type for url field * Fix lint issues
…is android (#14301) * Avoid to reset html to empty string if block is heading on android platform * Send empty tag flag from heading block to RichText
* Set minHeight based on fontSize or style. * Only use the styles to set the min-height.
* Fix placeholder position of block appender * Remove unused import * Change import position * Remove unused import in css file * Remove extra container view * Update travis.yml from master branch to fix CI issues
Tug
added
the
Mobile App - i.e. Android or iOS
* added hook blocks.onRemoveBlockCheckUpload called in componentWillUnmount to make sure to cancel upload if block is deleted * removed unused import * moving bridge-specific code to Image component - if the filter exists and returns true, the upload cancellation will be requested * using hook actions instead of filters
koke
approved these changes
Mar 21, 2019
Contributor
koke
left a comment
koke
left a comment
There was a problem hiding this comment.
Tested on WPiOS and looks good to me
aduth
reviewed
Apr 13, 2020
| @@ -0,0 +1,22 @@ | |||
| // Block Creation Components | |||
Member
There was a problem hiding this comment.
Can you help me understand why this file exists separate from index.js? Is it necessary that it does? Or did it just help simplify the migration? I'm concerned about the maintenance overhead in how new exported components need to be added to two files. And typically it's only made apparent after the fact (I'm encountering this in #21467).
Could we have a file of "common" imports? I mean, ideally all the components are made available in either environment, but I suppose it may unavoidable we'd need to exclude / include some as specific to one or the other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR merges the
rnmobile/developbranch back intomaster.Context: #14075
Prior work: #14375
How has this been tested?
Follow instructions in gb-mobile PR: wordpress-mobile/gutenberg-mobile#759